Coppermine areas break when using a table inside opentable :: Archived

t31os

At least i know its not the coppermine template files, because i've removed them from my theme so i'm just using subsilver templating on coppermine.

Looks fine at high res.... first 2 pics are at 1200+ resolution, 3rd is using 800x600 though its pretty apparent of the problem until u hit a high res.

t31os

I'd be tempted to recheck my code for a 3rd or 4th time but i'm pretty sure its as it should be, and since these issues are only with coppermine i have to wonder.

t31os

Well it seems has the worst issues, but any module that uses a FORM seems to push the tables out of whack.

t31os

I've noticed if i view source on problem areas the closing tags for </body> and </html> and not present, so the HTML is incomplete.

t31os

Areas in question from the coppermine block when viewing coppermine are...

My profile
Upload approval:
Review Comments
Groups

In saying that though, it seems even the pages that display correctly, they still do not complete the HTML, still missing the closing tags for body and html.

Anyone else have a working install of coppermine on their site to verify if this happens?

t31os

Ok, removed coppermine, and added a fresh copy, still same issue.

LOL, just checked while i was typing....... omg..... footer.html was missing some important HTML Confused

.....maybe something got lost when transferring across FTP, damn....

Will check coppermine again now...

t31os

I'm going to stop trying to get this working at less then 1024 res.

I have all pages working now, except the groups page which pushs things out of place.

I'll take a look at re-coding that part though.

Sorry for being a total tit, but i bet if i had'nt of wrote down everything as i went along i would never of found the problem.

All i can say is.. ' IM SUCH A TIT SOMETIMES.... ' i have no idea how the hell my footer lost those tags... Confused

t31os

Ok i have all working minus the groups page, and now i've made the change, looking at it, it was pointless being that size to begin with.....

groupmgr.php in modules/coppermine

Line 65

Code::

<input type="text" name="group_quota_'.$group['group_id'].'" value="'.$group['group_quota'].'" size="10" class="textinput" /> '.$lang_byte_units[1].'

Why that needs to be size 10 anyway is beyond me.... Confused

I changed this to...

Code::

<input type="text" name="group_quota_'.$group['group_id'].'" value="'.$group['group_quota'].'" size="5" class="textinput" /> '.$lang_byte_units[1].'

Any chance this could be updated in the CVS so i don't have to tell my users that my themes will break in 1 place, check it yourself, size 10 is really not needed, 5 leaves plenty of room.

I hate to edit outside the theme, but this is required.

t31os

Its getting annoying not being able to edit my own posts in this forum Confused

Anyways, back on topic..........

I'd also like to see checkboxes on pages such as the groups page instead of drop down menus that take up yet more space.

I believe that would be this area...

Code::

		foreach ($field_list as $field_name) {
			$value = $group[$field_name];
			$yes_selected = ($value == 1) ? 'selected="selected"' : '';
			$no_selected = ($value == 0) ? 'selected="selected"' : '';
			echo '
			<td class="tableb" align="center">
				<select name="'.$field_name.'_'.$group['group_id'].'" class="listbox">
					<option value="1" '.$yes_selected.'>'.YES.'</option>
					<option value="0" '.$no_selected.'>'.NO.'</option>
				</select>
			</td>
';
		}

I'd guess that someone here knows how to replace this with a checkbox function, like.....

IF CHECKBOX = checked, then value = 1 , etc.....

Yes i know thats far from being the code needed to work but i understand the principle, i think... Confused

t31os

t31os wrote:

Ok i have all working minus the groups page, and now i've made the change, looking at it, it was pointless being that size to begin with.....

groupmgr.php in modules/coppermine

Line 65

Code::

<input type="text" name="group_quota_'.$group['group_id'].'" value="'.$group['group_quota'].'" size="10" class="textinput" /> '.$lang_byte_units[1].'

Why that needs to be size 10 anyway is beyond me.... Confused

I changed this to...

Code::

<input type="text" name="group_quota_'.$group['group_id'].'" value="'.$group['group_quota'].'" size="5" class="textinput" /> '.$lang_byte_units[1].'

Any chance this could be updated in the CVS so i don't have to tell my users that my themes will break in 1 place, check it yourself, size 10 is really not needed, 5 leaves plenty of room.

I hate to edit outside the theme, but this is required.

Or if we implement the check box function we could do something like...

Code::

<td class="tableb">
				<input type="hidden" name="group_id[]" value="'.$group['group_id'].'" />
				<input type="text" name="group_name_'.$group['group_id'].'" value="'.$group['group_name'].'" size="12" class="textinput" />
			</td>
			<td class="tableb" style="white-space: nowrap;">
				<input type="text" name="group_quota_'.$group['group_id'].'" value="'.$group['group_quota'].'" size="3" class="textinput" /> '.$lang_byte_units[1].'
			</td>

Increasing the flexability of working within a fixed width 1024+

I can't be the only person wanting coppermine to do this...

NanoCaiordo

modules/coppermine/admin/index.inc got few fixes that might help you .... I'm not asking you to download the whole new file since it could easily break other thing, you are using 9.1.0.8 and latest cvs version is 9.1.2.5. But have a look at the changes, it might help you.