[approved] Individual query times :: Archived

Biggles · Posted: Fri Mar 24, 2006 7:54 am Post subject: [approved] Individual query times

While optimizing some queries for the website I administer I thought it would be handy to know the query time of each query rather than all of them summed so I could spot the slow ones more easily. For mysql 4.0 on Dragonfly 9.0.6.1, change lines 52-53 of your includes/db/mysql.php file from:

PHP:

$this->query_result = ($unbufferd) ? mysql_unbuffered_query($query, $this->connect_id) : mysql_query($query, $this->connect_id);
if (CPG_DEBUG || is_admin()) $this->querylist[$this->file][] = '<b>LINE '.$this->line.':</b> '.htmlprepare($query);

to:

Code::

$stime = get_microtime();
$this->query_result = ($unbufferd) ? mysql_unbuffered_query($query, $this->connect_id) : mysql_query($query, $this->connect_id);
if (CPG_DEBUG || is_admin()) $this->querylist[$this->file][] = '<b>'.round((get_microtime()-$stime), 4).' seconds - LINE '.$this->line.':</b> '.htmlprepare($query);

For 9.1.0.8 it's a little easier, add the following after line 30 of includes/db/db.php:

PHP:

var $querytime = 0;

Then, change lines 40-44 of includes/db/db.php from:

PHP:

if ($failed) {
  $this->querylist[$this->file][] = '<b style="font-color: #f00">FAILED LINE '.$this->line.':</b> '.htmlprepare($query);
} else {
  $this->querylist[$this->file][] = '<b>LINE '.$this->line.':</b> '.htmlprepare($query);
}

to:

Code::

if ($failed) {
  $this->querylist[$this->file][] = '<b style="font-color: #f00">'.round((get_microtime()-$this->querytime), 4).' seconds - FAILED LINE '.$this->line.':</b> '.htmlprepare($query);
} else {
  $this->querylist[$this->file][] = '<b>'.round((get_microtime()-$this->querytime), 4).' seconds - LINE '.$this->line.':</b> '.htmlprepare($query);
}

Finally, before line 143 of includes/db/db.php:

PHP:

$this->query($query, $bypass_error, $unbufferd);

add the following:

PHP:

$this->querytime = get_microtime();

Head-e · Silver Supporter Offline Joined: Apr 20, 2004 Posts: 937

*core feature!* that would be nice

djdevon3 · Gold Supporter Offline Joined: Aug 05, 2004 Posts: 4363

Geez Biggles you really tore into that one. Nice work. I hope it goes in as an admin option for cvs. Thanks for sharing it.

t31os · Posted: Fri Mar 24, 2006 4:44 pm Post subject: Re: Individual query times

I know this will come in handy, bookmark me thinks!! Very Happy

xfsunoles · Posted: Fri Mar 24, 2006 4:54 pm Post subject: Re: Individual query times

Nice Core Hack, i been looking for that a long time to add Queries Time in SQL Debug.

Phoenix · Posted: Wed Aug 30, 2006 11:40 am Post subject: Re: Individual query times

Stickied as a core reference - CVS updated.

spacebar · Posted: Wed Aug 30, 2006 2:29 pm Post subject: Re: Individual query times

This is awesome. Thank you much!

caladrius · Nice poster Offline Joined: Jan 25, 2006 Posts: 108

spacebar wrote:

This is awesome. Thank you much!

AWESOME addition biggles!