Mod Wanted - "go to page" text box

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

Does anyone know of a mod for the viewtopic and viewforum files to all me to add a "go to page" text field to the forums pages?

At present the page does all it's calculations about how many posts / pages there are, then generates the links in the pagination (1 2 3 ...200 next) - these links are to posts, not pages. When you go to page x, you are sending a link to post y.

I would like the reverse. To send it a page number like "page=20". It would then recognize that variable and then calculate which post number to start at, based on "no of posts per page * page".

If not then I'll try and crack it, but I'm sure this must have been done before.

Thanks

(I have looked for this without success on here, phpbb and nukecops and haven't found anything even though it seems a simple, useful mod. If it's somewhere obvious I apologise)

piraja

hqarrse wrote:

If it's somewhere obvious I apologise)

Me too!
Very interested about this kind of mod!

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

It's quite an easy programming tweak, but I'm pushed for time hence the 'has this been done before'. If no one comes to the rescue with the code I'll crack it tomorrow and post it on here.

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

OK, here's the forum pages mod (much easier than I expected):

In viewforum.php

change this (about line 35)

Code::


$start = (isset($_GET['start']) ? intval($_GET['start']) : 0);

to

Code::


$start = 0;
if (isset($_GET['start']))
{
	$start = intval($_GET['start']);
}
elseif (isset($_POST['startpage']))
{
	$start = $board_config['topics_per_page']*(intval($_POST['startpage']) - 1);
}

Then in themes/THEME/forums/viewforum_body.html add the following where you want your 'go to page' bit:

Code::

<form action="{U_VIEW_FORUM}" method="post" name="gotopageform">

(in here I have table / layout)

        <input name="startpage" type="text" size="3" maxlength="4" />
          <input type="submit" name="Submit" value="Go to Page" id="Submit" />
    
(also in here)

</form>

Topic pages to follow

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

And the topics:

viewtopic.php at about line 50:

change

Code::

$start = ( isset($_GET['start']) ) ? intval($_GET['start']) : 0;

to

Code::

$start = 0;
if (isset($_POST['startpage']))
{
	$start = $board_config['posts_per_page']*(intval($_POST['startpage']) - 1);
}
elseif (isset($_GET['start']))
{
	$start = intval($_GET['start']);
}

then in viewtopic_body.html

Code::


<form action="{U_VIEW_TOPIC}" method="post" name="gotopageform">


<input name="startpage" type="text" size="3" maxlength="4" length="3"/>
          <input type="submit" name="Submit" value="Go to Page" id="Submit" />

</form>

Neither of those has been run live yet so there's no guarantee there won't be side effects. Obviously I'll post any that I find once I start using it.

aptd · Heavy poster Offline Joined: May 04, 2007 Posts: 186

Looks good man, nice...

Eestlane

Good work.

What happens if wrong page number is used or maybe even letter instead of number?

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

Eestlane wrote:

Good work.

What happens if wrong page number is used or maybe even letter instead of number?

Wrong page numbers are OK - if they're too big you get empty threads or the most recent topics, but....

The character causes a database error page instead of just returning to the same page. I'll sort that out now.

piraja

Good work, hqarrse! Very nice!

Eestlane

If it's working well, I suggest adding it to core.

piraja

How about the "database error pages"? Any changes coming? Rolling Eyes

Eestlane

I think that the URL's where it goes to shouldn't work only with POST as if someone wants to bookmark that page or give a link for a friend (s)he can't do it if not using regular paging system.

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

I hadn't seen that, but it's not a big issue in my opinion so I'm not going to have a chance to tackle that one, sorry!

Eestlane

Well, I could do it myself also, if I would use it, so no problem.

Phoenix

The "page" you bookmark will become meaningless as time and posts progress.

I've lost count of the number of indexed "pages" I've found in a search where the result is useless as the topic/post is no longer there - in your own interest it is best not done.