Mod Wanted - "go to page" text box

Eestlane

I don't understand, Phoenix :S

piraja

How about same thing to the memberlist? Difficult to do?

Eestlane

I guess it is.

I have done the alphabetical letters to choose from for memberlist, though I never finished it...

piraja

Eestlane wrote:

I guess it is.

I have done the alphabetical letters to choose from for memberlist, though I never finished it...

Would you share it?

Eestlane

It's so not ready, that atm I wouldn't give it. I want to finish it sometimes, but atm I'm making other module...

piraja

Ok

No problem

Marcus81

I do like you said.. And this form works.. but page number don't listed like 1,2,3,4,5,6,7,8,9,10 ..

They still listed 1,2,3 ... 8,9,10.

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

Surely making page numbers like you've suggested would be crazy - once threads got beyond 20 pages or so you would have one hell of a list. The standard pagination is the only viable option surely?

piraja

hqarrse wrote:

And the topics:

viewtopic.php at about line 50:

change

Code::

$start = ( isset($_GET['start']) ) ? intval($_GET['start']) : 0;

to

Code::

$start = 0;
if (isset($_POST['startpage']))
{
	$start = $board_config['posts_per_page']*(intval($_POST['startpage']) - 1);
}
elseif (isset($_GET['start']))
{
	$start = intval($_GET['start']);
}

then in viewtopic_body.html

Code::


<form action="{U_VIEW_TOPIC}" method="post" name="gotopageform">


<input name="startpage" type="text" size="3" maxlength="4" length="3"/>
          <input type="submit" name="Submit" value="Go to Page" id="Submit" />

</form>

Neither of those has been run live yet so there's no guarantee there won't be side effects. Obviously I'll post any that I find once I start using it.

How about this with newest DF? Confused

Eestlane

Have you tested it, piraja?

piraja

Jap.. dont find this:

Quote::

$start = ( isset($_GET['start']) ) ? intval($_GET['start']) : 0;

The part of the viewforum was fine...

Eestlane

modules/Forums/viewtopic.php
Line 54:

PHP:

$start = ( isset($_GET['start']) ) ? intval($_GET['start']) : 0;

EDIT: BTW, she got it fixed. The problem was not in Dragonfly 9.2.1.

Phoenix

Can also optimize that "to" code to 1 line, if you wish

PHP:

$start =  isset($_POST['startpage']) ? $board_config['posts_per_page']*(intval($_POST['startpage']) - 1) : (isset($_GET['start']) ? intval($_GET['start']) : 0);

hqarrse · Diamond Supporter Offline Joined: Mar 20, 2005 Posts: 177

Whichever way you do it, there is a change needed to stop a MySQL error which comes from a LIMIT clause with a minus argument (LIMIT -20,20 in my case where 20 is the number of posts per page).

"startpage" needs to be tested for zero. If someone entered 0 in the go-to-page box they would cause the error, so replace:

isset($_POST['startpage'])

with

isset($_POST['startpage']) && $_POST['startpage'] > 0