Admin block is missing

[Eestlane]

I didn't dig into it before, but now I found I've got more serious problem.

The system block, named _ADMIN is missing, it's not showing up in admin->blocks.

I don't have any other blocks with that name, so that is not the problem.

I think I deleted it myself, because I had a block with same name, which was actually the admin block(I think), but converted to normal, custom block during the upgrade for some reason. So I deleted it by thinking I have the real block too, but it comes out I don't.

Weird.

[Phoenix]

It's not missing - the waiting content section is still there.

The other section with admin links is redundant and has been eliminated. It is inherently catered for by the css menu if you use that, otherwise simply create one using blocks admin if you really must have it.

[Eestlane]

I can't see a waiting content one in the list aswell.

[Phoenix]

Actually, I thought we had eliminated that useless links section - it's still there.

Not sure what you've done to your site, but they both exist.

[NanoCaiordo]

Topic title wrote:

Admin block is missing

Eestlane wrote:

I think I deleted it myself, because I had a block with same name, which was actually the admin block(I think), but converted to normal, custom block during the upgrade for some reason. So I deleted it by thinking I have the real block too, but it comes out I don't.

You say its missing but you are also confirm that you delete it

The conversion was part of the upgrade and worked correctly.

[Eestlane]

Sorry for the confusing explanation, I try again.

It seems

I checked my database backups.

Before upgrade:

Code::

INSERT INTO cms_blocks VALUES ('3', 'admin', 'Admin', 'test', '', 'l', '1', '1', '0', '0', '', '', '2', '7');

After upgrade:

Code::

INSERT INTO cms_blocks VALUES ('3', 'custom', 'Admin', 'test', '', 'l', '1', '0', '0', '0', '', '', '2', '7');

So, for some weird reason during the upgrade, my admin block was converted to nonsystem, custom block.
Ofcourse I could fix it now adding it via phpMyAdmin back, but it's weird that upgrade did that, isn't it?

It seems the upgrade changed 'admin' bkey to 'custom'.

So Dragonfly does upgrade Admin block from SYSTEM to CUSTOM?
Interesting, but in my localhost test site, Admin block remained SYSTEM block.

[NanoCaiordo]

What version were you upgrading from.

[Eestlane]

Database backup shows

Code::

INSERT INTO cms_config_custom VALUES ('global', 'Version_Num', '9.1.2.1');

And I think it was 9.1.2.1.


In df91.inc upgrade file I found:
For <9.1.2.8

PHP:

$installer->add_query('UPDATE', 'blocks', "bkey='custom' WHERE content!='' AND url='' AND blockfile=''");

And for 9.1.2.81:

PHP:

$installer->add_query('UPDATE', 'blocks', "bkey='admin' WHERE bid=".$row[0]);

(So that might be a problem? )

Ahaa, the problem is that my admin block was named
'Admin' not '_ADMIN' nor 'Administration'

[NanoCaiordo]

9.1.2.8 had this issue, and 9.1.2.81 will repair it.

In fact admin blocks was set to "custom" but then it will search the block name and set bkey as "admin".

Since you have renamed the admin block from the default _ADMIN or Administration (old nuke and cpg 8.x had that) it was not able to found it.

Searching by block id was not reliable since it would easily fail for many old sites so i felt like using the block name would create problems very few users.

Manually update bkey to "admin".

[Eestlane]

OK.
However, in 9.1.2.1 there was already bkey, so upgrade script could search by bkey.

[NanoCaiordo]

yep, but bkey was changed by 9.1.2.8 to "custom"

[Eestlane]

What about giving an exeption:

PHP:

$installer->add_query('UPDATE', 'blocks', "bkey='custom' WHERE content!='' AND url='' AND blockfile='' AND bkey!='admin'");

[NanoCaiordo]

At which point of the upgrade.

[Eestlane]

if (version_compare($version, '9.1.2.8', '<'))

[NanoCaiordo]

Quote::

9.1.2.8 had this issue, and 9.1.2.81 will repair it.