OK, back now.
So, what you say is that...
- 9.1.2.8 had the issue that it didn't convert 'admin' 'user' blocks with the right bkey
- 9.1.2.81 fixed 9.1.2.8 bug, or well tries to fix it.
But now, why to repeat the same bug, if I didn't have 9.1.2.8 before but an earlier version? So we could just change the line
| PHP: |
$installer->add_query('UPDATE', 'blocks', "bkey='custom' WHERE content!='' AND url='' AND blockfile=''");
|
to
| PHP: |
$installer->add_query('UPDATE', 'blocks', "bkey='custom' WHERE content!='' AND url='' AND blockfile='' AND bkey!='admin'");
|
for version_compare($version, '9.1.2.8', '<').
The fix by 9.1.2.81 can still stay or change it to:
| PHP: |
if (version_compare($version, '9.1.2.81', '<') && !version_compare($version, '9.1.2.8', '<'))
|
or for specific fix for 9.1.2.8 version just like that:
| PHP: |
if (version_compare($version, '9.1.2.8', '='))
|
Or do I misunderstand some facts?
Last example should probably be:
| PHP: |
if (version_compare($version, '9.1.2.8', '=='))
|