Probanner not working after update

[piraja]

After update ProBanner module is not working right. Cannot see the banner in header...

Tried to change the code in theme.php:

Code::

'S_BANNER' => ($banners) ? viewbanner() : '',

to:

Quote::

//'S_BANNER' => ($banners) ? viewbanner() : '', 'S_BANNER' => ($banners) ? pbbanner() : '',

But after that I get error:

Quote::

Fatal error: Call to undefined function pbbanner() in /var/www/pereklubi/themes/default/theme.php on line 78

What I need to do?

[Phoenix]

You need to contact the author of ProBanner.

Moved to the add-ons forum.

[piraja]

Thank you, will do that

[Phoenix]

Good - the reason we always insist on that is because,

a) it is our policy for 3rd party (active) mods to be supported on the author's site

b) it gives the author the chance to fix an issue for all users of that mod.

(applies to themes too)

[scetter]

In case anyone runs into the same problem.

When ever you upgrade DF to a new version always make sure you place the edits back into the files that are overwritten.

In this past case the index.php and admin.php files needed this line put back into them.

Code::

require_once('includes/ProBanner/pbfuncs.php');

ProBanner works fine with the latest release, just need to remember that you need to edit the core files for it to work properly.

cheers

[Phoenix]

Will it work with just one addition, to the footer?

[scetter]

Phoenix wrote:

Will it work with just one addition, to the footer?

Might work, never tried it. Would it make a difference if footer.php was called after the theme.php? Or does it?

If it does ok, then one edit is better than two.

[Phoenix]

Actually, instead of playing with even 1 core file, and since you already require a theme.php edit, simply add your include near the top of function themeheader() - that way you have included the file with the function you want to call within themeheader().

Much better to avoid core

[scetter]

But then it would require an edit to every theme.php file. That would be many for some sites.

[Eestlane]

It does anyway, doesn't it?

[scetter]

Eestlane wrote:

It does anyway, doesn't it?

Good point

[Eestlane]

Offtopic: You know, I actually wanted to give exact same reply as you did, scetter, but then the light went on above my head aswell.

[alyssa]

THANK YOU. I knew I was forgetting to edit something!

[noair]

Anyone have the Probanner module working with DF 9.2.1. In the event you have it working can you provide me with your copy?

Thanks

[scetter]

As far as I know it should still work. If you recently did an upgrade to your DF install you will need to re-edit the files.