Personal Pages v2.7.1 (MySpace/Facebook clone)

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

Hi Alyssa,

I did some more testing and went over the code. With a clean install I wasn't able to reproduce your problem, and while I did clean up some code, I don't think I saw anything related to your issue. I think it's probably not a problem in Personal Pages, but somewhere else. I could be wrong of course. :b

One possibility is that another profile block that loads before the Personal Pages block, is messing with the environment somehow. Another possibility is that one of your mods has replaced a dragonfly file with an altered/bugged version.

Testing the first possibility should be pretty straight forward:

Try renaming /modules/Your_Account/blocks/personal.php to aapersonal.php

Because the blocks load in alphabetical order, this should cause it to be the first profile block loaded. Then try loading someone's profile.

If it fixes the problem, then one of the other blocks is causing it. Let me know, and we can try to track down which block it is.

If it doesn't fix the problem, let me know and I'll see what we can try next.

Good luck!

-Andy

radoka

Got a swedish translation for this addon that I made. Interesting for anyone?

alyssa · Diamond Supporter Offline Joined: Nov 15, 2004 Posts: 773

Thanks I will try that.

Just a FYI though - it's a personal dev site that is locked down, and I am the only person that accesses it - so there is no chance at all of a mod or another admin or person affecting it in any way.

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

radoka: I'm interested, in fact, if it is ok with you, I could include it in future releases. You will be credited for the contribution of course. I think we currently include English, German and Dutch, so the more the merrier. Smile

You can e-mail it to me: personman_145 @ hotmail.com

Alyssa: Sorry, by mod I meant modification or module, rather than moderator. Anyway, I'll be interested to hear how it goes, either way.

alyssa · Diamond Supporter Offline Joined: Nov 15, 2004 Posts: 773

Crap - I had an issue with a production site with the personality pages - was allowing spammers to comment - hadn't noticed it, so thought I'd replace the files with these ones - and the same exact thing happened.

Interestingly enough - in the index.php file, there was a bit of broken code - on line 490

Code::

$blog_link = $BASEHREF.'?name=Personal&u='.$blog_author.'';

It needed to have index.php added so it looked like this so it would work:

Code::

$blog_link = $BASEHREF.'[b]index.php[/b]?name=Personal&u='.$blog_author.'';

If that is in the other installs, might want to fix it. My personality install is: Personal Pages 2.7.1

I renamed personal.php (in ../modules/Your_Account/blocks)to aapersonal.php, and NOW - the correct blog is showing in the member's personal page instead of the admin's personal page.

If they do NOT have a personal page - it is now causing an issue though:

modules/Your_Account/userinfo.php

* Notice line 205: Undefined index: board_email_form

modules/Personal/blocks/left/pictures-side.php

* Warning line 93: Missing argument 2 for get_pic_urls(), called in /home/databasename/public_html/modules/Personal/blocks/left/pictures-side.php on line 83 and defined
* Notice line 105: Undefined variable: mode
* Notice line 105: Undefined index:
* Warning line 93: Missing argument 2 for get_pic_urls(), called in /home/databasename/public_html/modules/Personal/blocks/left/pictures-side.php on line 83 and defined
* Notice line 105: Undefined variable: mode
* Notice line 105: Undefined index:
* Warning line 93: Missing argument 2 for get_pic_urls(), called in /home/databasename/public_html/modules/Personal/blocks/left/pictures-side.php on line 83 and defined
* Notice line 105: Undefined variable: mode
* Notice line 105: Undefined index:

I had replaced userinfo.php with the one from the extras dir.

I had uploaded this personal.php page from that install:

Code::

<?php
/*********************************************
  PERSONALITY - MODULE FOR CPGNUKE 9.0.6.1
  ********************************************

  author:       gtown
  date:         2006/10/14
  version:      2
  authemail:     admin @ germeringer.de
  authurl:      http://www.germeringer.de

  This module is based on the blogs module of
  DJMaze and Trevor from www.cpgnuke.com
  Special thanks to dcollis!

**********************************************/


if (!defined('CPG_NUKE')) { exit; }

get_lang('Personal');

$module = _PTY_BLOG;

list($module_title) = $db->sql_ufetchrow("SELECT custom_title FROM ".$prefix."_modules WHERE title='$module'", SQL_NUM, __FILE__, __LINE__);
    if (empty($module_title)) { $my_title = $module; }

echo '<br />';
OpenTable();
echo '<div align="left"><strong>'.$my_title.':</strong><ul>';
    
/***********************  MODULSTART */
/* Configuration */
//$cfg_comment_limit = 4096; // maximum length in characters for a greeting | set to 0 for no limit
//$cfg_comment_anon = false; // allow anonymous users to post greetings?
/* END Configuration */

global $MAIN_CFG;

if (is_array($MAIN_CFG['Personal'])) {
	$personal_conf = $MAIN_CFG['Personal'];
}

$pagetitle .= _PTY_TITLE;
require_once('includes/nbbcode.php');
require_once('modules/Your_Account/functions.php');

$username = $userinfo['username'];
$mode = (isset($_POST['mode'])&& $_POST['mode']!='') ? $_POST['mode'] : (isset($_GET['mode'])&& $_GET['mode']!='') ? $_GET['mode'] : '';

/* LINES FOR PERSONAL PAGE USE */
list($num_blogs) = $db->sql_ufetchrow("SELECT COUNT(*) FROM ".$prefix."_personality WHERE aid='$username' AND private=0 LIMIT 1");
/* LINES FOR PERSONAL PAGE USE END*/


    $result = $db->sql_query("SELECT * FROM ".$prefix."_personality WHERE aid='$username'");
    if ($db->sql_numrows($result) < 1) {
        cpg_error('<table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
        <tr><td class="row1" colspan="2" align="center" height="30">'.sprintf(_PTY_PERSONALERROR2).''.$username.''.sprintf("!").'</td></tr>
        </table>');
    }
    list($blog_id, $blog_author, $blog_title, $blog_text, $blog_private, $blog_timestamp) = $db->sql_fetchrow($result);
    $db->sql_freeresult($result);

    if ($blog_private && ($blog_author != $userinfo['username'])) {
        cpg_error('<table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
        <tr><td class="row1" colspan="2" align="center" height="30">'._PTY_PRIVATE.'</td></tr>
        </table>');
    }

    $result = $db->sql_query("SELECT * FROM ".$prefix."_personality_greetings WHERE bid='$blog_id' ORDER BY timestamp ASC");
    $blog_comments = $db->sql_numrows($result);
    $blog_text = decode_bb_all($blog_text, 1, $personal_conf['allow_html']);
    $blog_timestamp = formatDateTime($blog_timestamp, _DATESTRING);


/* PERSONAL PAGE USE: MENU WITH/WITHOUT "ADD" BUTTON START*/
    $result2 = $db->sql_query("SELECT id FROM ".$prefix."_personality WHERE aid='$username'");
    $id = $db->sql_fetchrow($result2);
    $db->sql_freeresult($result2);
    $id = $id[0];
    if ($num_blogs > 0){
    echo '<table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
    <tr><td class="catleft" colspan="2" align="center"><b><span class="gen">'.$blog_title.'</span></b></td></tr>
    <tr><td class="row1" colspan="2" align="center">'.$blog_timestamp.'</td></tr>
    <tr><td class="row1" colspan="2"><span class="gen">'.$blog_text.'</span></td></tr>
    </table><br /><table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
    <tr><td class="row1" colspan="2" align="center"><a href="'.'index.php?name=Personal&mode=display&id='.$id.'&comments=show'.'">'._PTY_COMMENTS_POST.'</a></td></tr>
    </table>';
    }

    if ($num_blogs == 0){
    echo '<table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
    <tr><td class="catleft" colspan="2" align="center"><b><span class="gen">'.$blog_title.'</span></b></td></tr>
    <tr><td class="row1" colspan="2" align="center">'.$blog_timestamp.'</td></tr>
    <tr><td class="row1" colspan="2"><span class="gen">'.$blog_text.'</span></td></tr>
    </table><br /><table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
    <tr><td class="row1" colspan="2" align="center"><a href="'.'index.php?name=Personal&mode=display&id='.$id.'&comments=show'.'">'._PTY_COMMENTS_POST.'</a></td></tr>
    </table>';
    }
/* PERSONAL PAGE USE: MENU WITH/WITHOUT "ADD" BUTTON END*/

	//*************************************
	// Display Comments
	//*************************************

        echo '<table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">
        <tr><td class="catleft" colspan="3" align="center"><b><span class="gen">'._PTY_COMMENTS.'</span></b></td></tr>';
        while (list($comment_id, $comment_blog, $comment_author, $comment_email, $comment_ip, $comment_text, $comment_timestamp) = $db->sql_fetchrow($result)) {
            $comment_ip = decode_ip($comment_ip);

            echo '<tr><td class="row1" valign="top" width="100%"><span class="gen">'.decode_bb_all($comment_text, 1).'</span></td><td valign="top"><center><a href="'.getlink('Your_Account&profile='.$comment_author).'">'.$comment_author.'</a><br>';

global $MAIN_CFG, $CPG_SESS;

//$username = $comment_author;
//$username = substr($username, strlen(_BY)+1);
$commenterinfo = getusrdata($comment_author,'user_avatar_type,user_avatar');

  if ($commenterinfo['user_avatar_type'] == 1) {
    $avatar = $MAIN_CFG['avatar']['path'].'/'.$commenterinfo['user_avatar'];
  } else if ($commenterinfo['user_avatar_type'] == 2) {
    $avatar = $commenterinfo['user_avatar'];
  } else if ($commenterinfo['user_avatar_type'] == 3 && !empty($commenterinfo['user_avatar'])) {
    $avatar = $MAIN_CFG['avatar']['gallery_path'].'/'.$commenterinfo['user_avatar'];
  } else if (file_exists('themes/'.$CPG_SESS['theme'].'/'.$MAIN_CFG['avatar']['gallery_path'].'/'.$MAIN_CFG['avatar']['default'])) {
    $avatar = 'themes/'.$CPG_SESS['theme'].'/'.$MAIN_CFG['avatar']['gallery_path'].'/'.$MAIN_CFG['avatar']['default'];
  } else {
    $avatar = $MAIN_CFG['avatar']['gallery_path'].'/'.$MAIN_CFG['avatar']['default'];
  }
  if ($avatar) {
    $avatar = '<a href="'.getlink('Your_Account&profile='.$comment_author).'"><img src="'.$avatar.'" alt="" /></a>';
    echo $avatar;
  }
	    echo '</center></td></tr>
            <tr><td class="row1" colspan="2" align="left">'._PTY_GREETPOST.' '.((!empty($comment_email)) ? '<a href="'.getlink('Your_Account&profile='.$comment_author).'">'.$comment_author.'</a>' : $comment_author).' | '.formatDateTime($comment_timestamp, _DATESTRING).'</td>
<br><table border="0" cellpadding="3" cellspacing="1" width="100%" class="forumline">';



}
echo '</table>';

/***********************  MODULENDE */
echo '</ul></div>';
CloseTable();

Hope this helps!

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

Hi Alyssa,

Ok, good news that we've at least got the block thing figured out. Smile

If you want to figure out exactly which block is causing the problem, here are some steps you can try: (If you don't want to go through all this, and are happy with the personal block loading first, you should be able to leave it as is)

rename aapersonal.php back to personal.php

If you view the list of files in /modules/Your_Account/blocks, sorted alphabetically, the culprit is probably one of the blocks that precedes personal.php in the list.

So from here, we can try disabling the blocks one at a time, to see which one is causing the issue. You can do this by renaming the file extension. Change the .php extension to .php_old or something like that. Do this one at a time and refresh a profile. When the bug goes away, you'll have found which block is causing the issue.

Then you could take it up with the author of that block, or I can take a look at the code and see what might be the problem. The author will probably know the code better, but I could give it a shot.

Regarding the other issues, I did do some clean-up work on the profile block. I'll look in to the other issues you've mentioned, too.

One change I made was, rather than showing an error in the profile for users who don't have a personal page, we simply show nothing at all. Just seems a bit cleaner this way.

Once I look in to your other issues, maybe I'll put up a new test version of the profile block, and/or release a new version of personal pages, depending on how many changes are involved.

Thanks for reporting your issues, I'll see what I can do! Smile

-Andy

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

Ok, the error messages you are seeing should be safe to ignore. You are probably only seeing them because you are an admin with some debugging options turned on. Normal users shouldn't see them.

I'm working to clean it up though, I have a fix for the picture block errors:

Open /modules/Personal/blocks/left/pictures-side.php

Go to line 83 which should look like this:

PHP:

<a href="' . $BASEHREF.get_pic_urls($row) . '">

and change it to this:

PHP:

<a href="' . $BASEHREF.get_pic_urls($row, 'fullsize') . '">

I'll continue looking in to the other issues, stay tuned. Smile

If you'd rather not do this manually, I expect I'll release a new version fairly soon, once I look in to the rest of the issues. Thanks again for the feedback!

-Andy

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

As far as this message goes:

modules/Your_Account/userinfo.php

* Notice line 205: Undefined index: board_email_form

I seem to get the same message with the personal block disabled and the default copy of userinfo.php, so it's probably safe to ignore, and just a Dragonfly CMS thing. I seem to get it on any profile that isn't mine, regardless of whether they have a personal page or not.

Are you sure you weren't getting this message before the module?

-Andy (still diggin')

Phoenix

It is caused by DF and it's non-fatal - $board_config isn't globalled - I fixed it in AccountPlus but I don't think I updated cvs yet.

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

Phoenix: Ahh cool, just glad it's nothing I've broken. Smile

I've globaled it and it seems to work fine.

Alyssa:

Quote::

Interestingly enough - in the index.php file, there was a bit of broken code - on line 490

It needed to have index.php added...

What happened before you added index.php? Did it make a broken link? or cause an error?

Also, when you load a Personal Page, in the block that shows the Personal Page URL, is the link broken with "index.php" missing as well?

Just checking, because if it is broken there, there are other places I've used the same code, and I'll need to make sure to fix it everywhere.

The fix I'm toying with at the moment is this:

PHP:

$blog_link = $BASEHREF.$mainindex.'?name=Personal&u='.$blog_author.'';

It should do pretty much the same thing, only it gets the index name from Dragonfly's settings.

-Andy

personman · Heavy poster Offline Joined: May 29, 2007 Posts: 152

In the future, I'd like to look in to adding spaces for people to enter their facebook URL, twitter feed, diggs and all that good stuff. Maybe even add blocks to display them...

It'll probably be pretty involved and may involve replacing some dragonfly files, so not sure when I'll get to it.

MyStur

wow this is a great feature.

is it possible that you include this to for www.sitetalk.com

register for free and see it.

This community is better than facebook, myspace, netlog and so one

it had everything

but a grate feature

PoKo · Supporter Offline Joined: Aug 28, 2005 Posts: 148

Will this module work with the old 9.0.6.1 release of DF?

keekwai

Hi

What's happened to the download link?