[Aforo]

I was studing "functions_post.php" and I found a posible enhancement for notifications.

functions_post.php is only used by modules/Forums/posting.php (at least I think so)

I think that the notification function has a small problem when yu are a small forum o when you are starting.

The problem is $user_id_sql
This variable keeps suspended users. In a small site dosn't matter... but when you have 400 suspended users (or more) it's not so nice.

It's not ver efficient compare the user with 400 users (suspended) each time that you send a email to the users.

My proposition is that when you suspend a user (in admin pages) the function must delete all suscriptions of the user (topics, bulletin, forums watch...)

And of this way, functions_post.php doesn't need to look for suspended users.

[Phoenix]

If we discerned between banned and suspended, that would work - problem is that stripping subscriptions is harsh for a temporary suspension.

Might pay to consider BrokenCrust's member delete mod.

[Aforo]

Hi, Phoenix. Thak you for your answer.
I'm talking about suspended because suspended for me is a member that haven't rights for receiving any service of website (specially alerts). Most of the time is a spammer (in this case never is temporary). But even when can be a temporally suspension... user must suscribing again to every topic or forum.

I prefer don't delete user because, as I said before, most of the time is a spammer.

Solution can be:
in the file admin/modules/users.php around line 130 insert the next code (only red part):

In

Quote:

if(!($memberinfo = getusrdata($_POST['id']))) {
echo _NOINFOFOR.' <strong>'.$username.'</strong>';
showfooter();
} else {
// for deleting user suscriptions
if($_POST['user_suspend'] == 1) {
$db->sql_query("DELETE FROM `".$prefix."_bbtopics_watch` where user_id='".$_POST['id']."'" );
$db->sql_query("DELETE FROM `".$prefix."_bbforums_watch` where user_id='".$_POST['id']."'" );
}
// End of mine
$module_name = 'Your_Account';
require('modules/Your_Account/edit_profile.php');
saveuser($memberinfo);
}

After you must delete all suspended users suscriptions to topics or forums in Mysql:

Quote:

DELETE FROM `nuke_bbtopics_watch` where user_id='(suspended_user_id)';

And now you don't need "$user_id_sql" query in functions_post.php for each email.

I think that is more efficient.

In a small place you have not problem with "$user_id_sql", in a medium place (as Google Earth with 6.000 users) you start loosing some email (only some emails). But in a big place with more than thousand people suspended can be not so nice.

I'm testing this change in Google Earth. By the moment is ok.

For websites bassed in forum spammers is allways a big problem.