Bad Company 2 Stats Module

[matuck]

Not sure. alot of those problems because the way its originally coded.

I have some ideas to improve the system greatly but will take a major rewrite of the way the system does things.
Unfortunately I'm not gonna spend that much time on it.

Right now every time pages are loaded its hitting an external site to load player stats. My ideas are to cache some of this in the database so its not fetched every time.

Also because of the way the system work now is there is problems with variables getting overflowed or undefined.

Most of this can be fixed by using a database instead of loading every bit of the data from the external api.

[Kinsman]

True, I see one guy is pulling the data, then forming an XML with it.

For now it does work, and looks 100%, great job.

[Genocide]

the problem i was experiencing with the player name links not working within the blocks is now fixed

just need to edit the blocks for it to work:


block-BFBC2_Stats_name.php
search line 77:
$content .= ' <td align="center"><img src="modules/'.$modname.'/images/Ranks/'.$stats[$out]['most_used'].'.png" alt="" style="vertical-align: middle;" /> <a href="modules.php?name='.$modname.'&amp;mode=view_profile&amp;pid='.$stats[$out]['name'].'">'.$playername.'</a></td>';

change to:
$content .= ' <td align="center"><img src="modules/'.$modname.'/images/Ranks/'.$stats[$out]['most_used'].'.png" alt="" style="vertical-align: middle;" /> <a href="index.php?name='.$modname.'&amp;mode=view_profile&amp;pid='.$stats[$out]['name'].'">'.$playername.'</a></td>';


block-BFBC2_Stats_full.php
search line 86
$content .= ' <td align="center"><img src="modules/'.$modname.'/images/Ranks/'.$stats[$out]['most_used'].'.png" alt="" style="vertical-align: middle;" /> <a href="modules.php?name='.$modname.'&amp;mode=view_profile&amp;pid='.$stats[$out]['name'].'">'.$playername.'</a></td>';

change to:
$content .= ' <td align="center"><img src="modules/'.$modname.'/images/Ranks/'.$stats[$out]['most_used'].'.png" alt="" style="vertical-align: middle;" /> <a href="index.php?name='.$modname.'&amp;mode=view_profile&amp;pid='.$stats[$out]['name'].'">'.$playername.'</a></td>';

[Genocide]

matuck wrote:

if you are seeing _TITLE_SCORE your language file did not upload properly if you are using english.

the language file is in the right place but obviously not working for some reason

[matuck]

think thats part of the variable overflow. i was talking about.

[Kinsman]

heres the 2 blocks i fixed. all links now open the module on a new page.

[Genocide]

not sure how but these new blocks have corrected the problems i got with the language file

i alter the code for myself so the links opened up within the same page rather than open a new one.

thanks

[Kinsman]

No problem, I just manually wrote the titles, and fixed the links.

[Kinsman]

We suddenly started getting a lot of this error, no idea what changed, but switching back to display by game alias gets rid of it for now.

Code::

Fatal error: Call to undefined function displayerror() in /home/bik47463/public_html/junglewraiths.net/modules/BFBC2_Stats/index.php on line 208

Line in question says this.

Code::

DisplayError(_TITLE_PNOTFOUND._GOBACK, true);

[greenday2k]

use (_TITLE_PNOTFOUND._GOBACK, true); instead?
or trigger_error(_TITLE_PNOTFOUND);

[BobCat]

i would like to throw a big Thanks to those involved in getting this module going and working, great stuff.

Nice site Kinsman, great to see a AU gamers site using DragonflyCMS.

[Kinsman]

Thanks, it serves us well.