[earth]

includes/DB/db.php changes noted and running into a bug in pronews with linking from the forums for comments and got a few errors and was wondering if this is totally correct in 9.2.3 and what is unset vs null results functions?


9.2.3

PHP:

$query_id = NULL;

9.2.1

PHP:

unset($query_id);

[InspectorClueNo]

sorry earth if I don't understand your question ... do you have a bug in pronews caused by the change in cvs? do you want to know the difference between query_id be null instead unset?

[earth]

not sure inpspectorCN, yes there is a bug with pronews it seems, that is related and just thought would ask here to see if there is problem, as I updated with new db.php and then replaced it and not sure that is the way to fly!

[NanoCaiordo]

Since you think it's related to the specified cvs update and since you have all details and the required module is already installed, did you try reverting the code back to see if pronews's bug disappear.

[earth]

yes, the issue went away, with the db.php rollback...only file changed.

note in my pronews posts on it, for more description, on the issue and errors, as this may be a bug report and this is 9.2.3 that is in the downloads posted here, presumably not cvs, and not df10, as I get confused on what is what, as clear download of cvs, df10, 9.2.3 branch, with details of each defined, like on the homepage, might help!

[InspectorClueNo]

As far I understood it's like a cvs snapshot but for the 9.2 branch ... nano called this something like a pre RC if I remember correctly ... hope it puts some light on it

[earth]

thanks, I read that, however nano may not be as attention deficit as I am, as you feel me on the clarification on the homepage?

Like up top big download icon image with say 3 releases posted
version may not be correct here


DF 9.2.1.X stable release currently with green light on it
df 9.2.3.x Branch Snapshot with descript yellow light
df 10 cvs with a red light and descript

could be ajax jquery where you hover over the one package and and the info pops up and the direct download link, no running around, no captcha, no bs.

[Eestlane]

In case someone wanted to know difference between NULL and unset, then unset doesn't remove value from memory, while NULL would. Probably more important, when used pointers as PHP probably does garbage collection once in a while anyway.

[NanoCaiordo]

Unset will remove the variable name and the value, marking the memory as reusable.
Null instead will only remove the value while maintaining the variable active.

At the end of the script every variable, or any object in general, will lose their value but the memory chunk used will still remain in the memory and marked as reusable.

User script side.
Unset, will practically mark the variable as it doesn't exists anymore.
Null, variable still exists but has no value.
Depends how your script work, you should choose null or unset accordingly.

Performance wide.
null is way faster then unset.
no noticeable memory difference when using either null or unset.

[Eestlane]

unset would remain the value, if anything still uses it, though.

Example:

PHP:

// unset($a)
$a = 5;
$b = & $a;
unset($a);
print "b $b "; // b 5

// $a = NULL;
$a = 5;
$b = & $a;
$a = NULL;
print "b $b "; // b
print(! isset($b)); // 1

?>

[NanoCaiordo]

No one said anything about references but thanks to share your findings.

Earth, this is an easy example about null vs unset:

PHP:

$a = null;
var_dump(isset($a)); #false
var_dump(is_null($a)); #true

unset($a);
var_dump(isset($a)); #false
var_dump(is_null($a)); #warning

isset() and empty() will never give out warnings because these are prepared to deal with unset variables.

unset will remove the variable from the script and if you use any other function then isset() or empty() you will get undefined variable warnings.

However php.net offer an online documentations with plenty of users comments that comes very handy if you want to extend your knowledge.

[earth]

thank you nano, for taking the time to respond, as was more concerned about how the change impacts and relates to us/things here, than what understanding gained by reading the manual for php.


Thanks again!


P.S. Sure php6 is being discussed around here, so will search for where, before mentioning it here!

[NanoCaiordo]

Going back to the main topic, I will need to look into it since it was not supposed to create any issue, site or modules wide.

I made the change to remove few warnings but I guess wasn't the right one to do.

Are you able to localize the source of the bug? hint: must start from a sql query.

If so, copy the query + few lines before and after the query here.

[earth]

have you tried to upgrade from any previous version to 9.2.3.X, as you have to log out and back in, to see main admin options, and the forums not installing correctly or something, bug, could be related...as a guess, as it happen on 5 upgrades, as swapping back resolved it, if you want, will give you admin account at one of our dfa test sites where you can replicate and see it for yourself, via link and if you would like ftp access to change the file back and forth and if you need db access, as well, to modify anything on the test site, as trying to get full on demo out and notice you asking djmaze about radmin and was wondering what that is in regards to, and anyways, will not go off topic here, further and will reproduce the error later on, if did not post the details in pronews thread, as guess left that part off and have to add the promote forum topic hack on an install, so chances are will see it, as already reverted the file and error goes away and it functions as intended.

Little busy today and tomorrow, so if you do not get a response back. please forgive it, as Tuesday and this week, should be around more and available~!