9.2.3.3

[NanoCaiordo]

This will be most likely the last 9.x release.
From now on only security fixes will make to 9.x code.

Test dragonflycms.org/Downl...ls/id=540/ and comment here.

If you believe that a bug did not get enough attention, please let me know.

[BrokenCrust]

Woot!

What's new? i.e. What do I need to test?

Is this 9.x CVS or RC1 or 9.2.3.3 Final?

[greenday2k]

Dragonfly X! FTW, finally to come ¡some day! =)

[NanoCaiordo]

Just double checking that all should work as suppose to before an official release, our changelog correctly show most of the changes.

And as mentioned already, if you believe that a bug did not get enough attention (eg reported in forums) let us know.

[layingback]

Has this one been evaluated? If not, any chance?

I haven't tested, but I think it is simply a matter of changing call to _tpl_include() to add 2nd param of true in INCLUDE code in template_inc.php.

Inclusion now rather than later, should mean that we can rely on <!-- INCLUDE for 10 rather than having to still use the hack. (Will still need to include hack in templates coded for 9.2.x in case running on earlier version).

Thanks!

[NanoCaiordo]

dragonflycms.org/Proje...s/id=1122/

Most of the times you wont need to include the same template over and over, so it will include_once. Simply add false to the parameters list and it should work.

[layingback]

Any template which repeats can encounter this issue. How to I add false to <!-- INCLUDE pronews/pn_art_foot.html --> ? I.e what is the syntax for parameters? <!-- INCLUDE pronews/pn_art_foot.html false --> stops it working for even the first one. Ditto <!-- INCLUDE pronews/pn_art_foot.html $include='false' -->

[greenday2k]

<!-- BEGIN something -->
<!-- IF SHOWPICTURE -->
!-- INCLUDE pronews/pn_art_foot.html false -->
<!-- ENDIF -->
<!-- END something -->

Or:

<!-- BEGIN something -->
<!-- IF SHOWPICTURE -->
<img src="">html code that could be repeated every time
that something.showpictura is true etc
<!-- ENDIF -->
<!-- END something -->

[layingback]

Thanks for the help, but <!-- INCLUDE pronews/pn_art_foot.html false --> doesn't work - that's my point.

Line 54 of includes/classes/template_enc.php

Code::

preg_match_all('#<!-- INCLUDE ([a-zA-Z0-9\_\-\+\.\/]+?) -->#', $code, $matches);

effectively prevents you passing parameters to INCLUDE.

But then maybe it doesn't matter because on line 118:

Code::

case 'INCLUDE': $temp = array_shift($include_blocks); $compile_blocks[] = '<?php $this->_tpl_include(\''.$temp."'); ?>"; $this->_tpl_include($temp, false); break;

But I'm suspicious of the 2 calls to _tpl_include, the first without , false, the 2nd with.

Indeed calling this code includes/classes/template.php line 207:

Code::

// Include a seperate template function _tpl_include($filename, $include = true) { $handle = $filename; $this->filename[$handle] = $filename; $this->files[$handle] = $this->root . '/' . $filename; $filename = $this->_tpl_load($handle); if ($include) { if ($filename) { include_once($filename); return; } eval(' ?>' . $this->compiled_code[$handle] . '<?php '); } }

with , false appears to me to effectively be a no-op.

I see that Bug 1122 was closed as 'Bogus' (!?), but the explanation of

Quote::

Please double-check the documentation and the instructions on how to report a bug.

when the link is to the top level of the entire documentation, doesn't advance my understanding 1 bit, I'm afraid.

[BrokenCrust]

Is there really no release documentation?

I'm not so interested in what lines of code have changed, but rather a list of fixes and new features.

[NanoCaiordo]

Changes in CVS, no need to add any parameter.

[NanoCaiordo]

@BrokenCrust dragonflycms.org/Changelog/

[BrokenCrust]

Thanks Nano that link is most helpful.

Is it possible to make the terminal release of 9.x as 9.3.0 to give clarity?

Also can you explain what "Make the system more user friendly" means in practice?

[NanoCaiordo]

Make the system more user friendly, sarah wrote:

The default settings should all be whatever I want them to. This will be guessed using the intuitive ESP technology Also it should dispense beer, pie and coffee. Maybe sandwiches in a future version

It's a joke

[BrokenCrust]

LOL. Pies and beers. I look forward to installing it. If after 20 minutes of staring at the screen and thinking about pies, one doesn't turn up - I'll raise a bug report.