[fixed] problem with BBCode

gprovostjr · Posted: Tue Jan 17, 2012 1:59 am Post subject: [fixed] problem with BBCode

I have a weird problem with my BBCode, When I ry to use it to center and bold text and then add a bunch of image links and then center and bold some more text only the first center and bold commands work. I tried it here and previewed it and it worked fine but on my site it does not work correctly. I looked around here and do not have the same problems as most of the other BBCode posts, but of course I might have missed one.

If anyone can help fix this problem, I would appreciate it, as it is very annoying.

Example of what does not work on my site.

Code::

[align=center][b]Commissioned Officers[/b][/align]

General [Gen] - Commanding officer of the 5MC
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Gen.png[/img]

Colonel [Col] - Second in command of the 5MC
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Col.png[/img]

Major [Maj] - Oversee the working of the Captains in management of the Companies. Also makes sure that the Captains are training the Lieutenants to be adequate future Captains.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Maj.png[/img]

Captain [Cpt] - Captains command a company consisting of 2 - 4 Platoons. They oversee all members in their company, make recommendations based on progress, and ensure everyone has the tools and knowledge required to advance as a marine.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Capt.png[/img]

1st Lieutenant [1Lt]- 1st Lieutenants lead a platoon of up to 3 squads, if needed a 1st lieutenant will be chosen to assist his Captain.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_1stLt.jpg[/img]

2nd Lieutenant [2Lt]- As a 2nd Lieutenant you will be learning and assisting a 1st Lieutenant in running a Platoon of 3 squads. 
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_2ndLt.jpg[/img]

[b][align=center]Warrant Officers(Specialty Ranks)[/align][/b]

Chief Warrant Officer [CWO] - They manage over the sections of Warrant Officers, Directing them into what needs to be done/changed.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_CWO5.jpg[/img]

Warrant Officer [WO] - Warrant officers are those Marines who have had the training but are better suited in other areas. (Website editing, Making videos, Graphics, Recruiting, ETC.)
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_WO.jpg[/img]

[align=center][b]Non-Commissioned Officers[/b][/align]

Sergeant Major [SgtMaj] - Sergeant Majors are Squad leaders. They lead 3 fireteams on the battlefield and coordinate their attacks to effectively secure the objective.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_SgtM.png[/img]

First Sergeant [1stSgt] - First Sergeants are Squad leaders in training. They assist, shadow, and learn from their Sergeant Major.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_1stSgt.png[/img]

Master Sergeant [MSgt] - Master Sergeants are veteran fire-team leaders. They are given the more challenging tasks to complete.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Msgt.png[/img]

Staff Sergeant [SSgt] - Staff Sergeants have some experience as a fireteam leader, just not a veteran quite yet.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Ssgt.png[/img]

Sergeant  [Sgt]- You become a sergeant by showing strong leadership qualities and by proving to be a successful fireteam leader.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Sergeant.png[/img]

[align=center][b]Enlisted Marines[/b][/align]

Corporal [Cpl] - Corporals are veteran soldiers on the battlefield. As a Corporal you will take your first steps into leading a fireteam.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_Corp.png[/img]

Lance Corporal [LCpl] - You earn this rank upon successful progression of your skill, behavior, and activity as a member of 5MC.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_LC.png[/img]

Private First Class [PFC] - You are expected to know our rules and code of conduct and follow them along with all orders without question.
[img]http://5thmarinecorps.hostzi.com/images/ranks/rank_PFC.png[/img]

Private [Pvt]- Privates have under gone the process of recruitment and have been placed in a fireteam. They have earned the title of MARINE.

[align=center][b]Unofficial[/b][/align]

Recruit [RCT] - (Generally a 24hr - 48hr period) Your still in training, you haven't earned the right to call yourself a "Marine!" Just like being at paris island. You are nothing until you are formed here into something great. A Marine...

only the first and last align and Bold commands work.

InspectorClueNo · Heavy poster Offline Joined: Mar 26, 2008 Posts: 211

try changing

Code::

[b][align=center]Warrant Officers(Specialty Ranks)[/align][/b]

with

Code::

[align=center][b]Warrant Officers(Specialty Ranks)[/b][/align]

it may work if you lucky ... even if you shouldnt have that problem in first place ... is it a modified bbcode? did you tried using df originals?

layingback · Forum Admin Offline Joined: Apr 19, 2004 Posts: 1040

I think you have a corrupt, broken or out-of-date includes/nbbcode.php. I've just tried your text on my extended nbbcode and it works fine. Also tried with the original 9.46 version from 9.2.1 and it works fine with that too.

Re-download your version of DF if necessary, and re-upload includes/nbbcode.php?

gprovostjr · Posted: Tue Jan 17, 2012 11:18 am Post subject: Re: problem with BBCode

thank you i will do that.

gprovostjr · Posted: Tue Jan 17, 2012 4:21 pm Post subject: Re: problem with BBCode

InspectorClueNo, I had it the other way first and only changed the bold command to the outside to see if it made a difference.
I have only DF 9.3.2.0 files, nothing custom, except for the theme, which i use groundpounder.

Layingback, I tried your advice. The files after I downloaded them again and compared them were different sizes, but when i uploaded the new nbbcode.php it gives me the same exact problem. I also re-uploaded the bbcode.js file, which was the same size, and cleared my browser cache, and still it wont work.

gprovostjr · Posted: Tue Jan 17, 2012 4:27 pm Post subject: Re: problem with BBCode

OK I put the old one like you mentioned from the copy of 9.2.1 i had, and now it works.... SO is this a bug in 9.3.2.0 version or what?

layingback · Forum Admin Offline Joined: Apr 19, 2004 Posts: 1040

Sorry, I didn't catch that you were using 9.3.2.

I don't use it myself, but I loaded up a 9.3.2 test site and sure enough the only headings which are centered and bolded are the 1st and the last ones. This remaining 3 are in normal font left aligned.

In my case this is on a standard DF config, no changes beyond installing 1 module. So I think you have found a bug in 9.3.2 IMHO.

layingback · Forum Admin Offline Joined: Apr 19, 2004 Posts: 1040

We x-posted above Smile

But we seem to have come to the same conclusion via different routes.

I've diff'd the original 9.2.1 and 9.3.2 versions of nbbcode.php and the differences appear to fall into 3 areas:

Renaming the smilies popup - can't be that.

Changing the literal type from single to double quote format - can't be that.

So that only leaves the new test/conversion sequence on the img handling code around line 504.

The purpose of the new code is beyond me, so I'll leave for Nano, hopefully he'll take a look.

It is consistent with the found results though - the only headings which were formatted correctly did not follow a \img.

gprovostjr · Posted: Tue Jan 17, 2012 5:04 pm Post subject: Re: problem with BBCode

yeah, I agree. thanks for the help, I wouldn't have thought of using the older version if not for your post Wink

I need to quit trusting newer versions like that Wink

Hopefully this will get corrected for version 10

NanoCaiordo · Posted: Wed Jan 18, 2012 12:14 am Post subject: Re: problem with BBCode

A while ago we decided to run a maintenance release for v9, which will include the latest bug reports. This issue, obviously, will be corrected for the release.

Thanks for pointing this out.

Phoenix · Posted: Wed Jan 18, 2012 2:25 am Post subject: Re: problem with BBCode

It should be noted that "older" versions are less secure than the latest version, even with its minor flaw, so you should keep faith with the latest release if you don't want security issues - the choice, and risk, is always yours.

NanoCaiordo · Posted: Sat Jan 21, 2012 7:54 am Post subject: Re: [bug] problem with BBCode

Now fixed in v9 CVS.

layingback · Forum Admin Offline Joined: Apr 19, 2004 Posts: 1040

Nano, Thanks for fixing. But can you post the diff for v9 fixes pls? (There's no way that I can see to display the diff on a v9 module - there's no 'Differences to 9.48.2.6' link as there would be for v10 and used to be for v9 - both the version # and view links display the whole file.)

Phoenix · Posted: Sat Jan 21, 2012 9:15 am Post subject: Re: [fixed] problem with BBCode

No need - maintenance release is imminent.

However, dragonflycms.org/cvs/h...a=9.46.2.6

NanoCaiordo · Posted: Sat Jan 21, 2012 11:10 am Post subject: Re: [fixed] problem with BBCode

Regularly posting links for every change would be not feasible at all.
This bug is also not considered as urgent, and some times in this cases like this i feel to skip diff files ... I also can't do it all.

However, all those changes will be quickly followed by a new maintenance release, with some extras.

To advertise all my changes I've added a rss block, right side.
It displays all commits and all related files i had to change, and if someone is really interested in a particular change could browse our cvs module and access all diffs, I still prefer an entire CVS sync then single patches.

Anyways, soon a v9 maintenance release to be released while v10 is undergoing tremendous changes Smile