CPG-Nuke League for PR1 (and above) :: Archived

Phoenix

PHP:

if (!defined('ADMIN_PAGES')) { exit; }
if (!can_admin()) { die('Access Denied'); }

fcxbytes · Newbie Offline Joined: Sep 02, 2004 Posts: 20

Good.
And if the file has something like this in the start

PHP:

$module_name="League";
get_lang($module_name);
include_once('modules/$module_name/constants.php');
include_once('modules/$module_name/util.php');
global $db;

if (!defined('ADMIN_PAGES')) { exit; }
if (!can_admin()) { die('Access Denied'); }

should it be ordered like this?

PHP:


if (!defined('ADMIN_PAGES')) { exit; }
if (!can_admin()) { die('Access Denied'); }

$module_name="League";
get_lang($module_name);
global $db;
include_once('modules/$module_name/constants.php');
include_once('modules/$module_name/util.php');

fcxbytes · Newbie Offline Joined: Sep 02, 2004 Posts: 20

Isn't there also a change about how the global variables work?
I suppose the first block of code I posted is correct then.

Phoenix

yes - needs to be at the top to prevent the file from working.

fcxbytes · Newbie Offline Joined: Sep 02, 2004 Posts: 20

I remind that get() should be replaced with $_GET[''].

PHP:

// Is this correct?
   while (($rows = $db->sql_fetchrow($result))) {
      $name = getTeamName($rows[tid]); 
//change to 
      $name = $_GET['TeamName']($rows[tid]);

fcxbytes · Newbie Offline Joined: Sep 02, 2004 Posts: 20

I have another question concerning Header("Location: address"); .
I know It should be changed to url_redirect(getlink('address'));

PHP:

// all ok?

xfsunoles

Code::

  url_redirect(adminlink('leagueCreate'));

fcxbytes · Newbie Offline Joined: Sep 02, 2004 Posts: 20

This is my first (huge) job in php.
So far I managed to port some files...
I'm going to drop league.php file here.

Maybe there's a god out there that is interested in checking out my progress and pointing some errors I may have done.

RedGerry

I should have an operational version of RG_Sports under Dragonfly in the next couple of weeks.

Questtion? Do I need to submit this to anyone for approval/certification. As far as I can see it meets all the requirements however I'd be happier with someone checking it.