Projects ⇒ Bugs ⇒ #1123: nbbcode w3 tidy warning messages ⇒ CPG Dragonfly™ CMS
Bug #1123 nbbcode w3 tidy warning messages
Project: Dragonfly 9.0.3 -> 9.3 Category: Warning Message
Submitted: Thursday, December 09, 2010 (10:38:37) Modified: Tuesday, March 15, 2011 (08:52:26)
Status: Closed Assigned to:
PHP Version: Irrelevant HTTPD Server: Apache 2.2

View/Vote Add Comment

by: layingback
Description:
------------
21 warning messages per smilies table (ie 42 in News or Pro_News which sport 2 smilies tables).

Reproduce code:
---------------
Simply validate. (But if using FF plugin, you'll need an Error-free posting page in order so see Warnings as Tidy is only run if Validate is run to clean.)

In nbbcode the line:
$content .= "<td><a href=\"javascript:emoticon('".$form."', '".$field."', '".$data['code']."')\"><img src=\"" . $smilies_path . $smile_url . "\" style=\"border:0;\" alt=\"".$data['emoticon']."\" title=\"".$data['emoticon']."\" /></a></td>";

needs to have the 2 spaces removed between javascript parameters. No spaces are allowed in URI.
$content .= "<td><a href=\"javascript:emoticon('".$form."','".$field."','".$data['code']."')\"><img src=\"" . $smilies_path . $smile_url . "\" style=\"border:0;\" alt=\"".$data['emoticon']."\" title=\"".$data['emoticon']."\" /></a></td>";

That takes care of 20 Warnings!

The line
$content .= "<td colspan=\"$s_colspan\" class=\"nav\"><a href=\"$url\" onclick=\"window.open('$url', '_smilies', 'height=200,resizable=yes,scrollbars=yes,width=230');return false;\" target=\"_smilies\" class=\"nav\">$smilies_more</a></td>";

Needs to have _both_ refs to _smilies changed to smilies (or similar) as _smilies is invalid (not one of _blank, etc.)
$content .= "<td colspan=\"$s_colspan\" class=\"nav\"><a href=\"$url\" onclick=\"window.open('$url', 'smilies', 'height=200,resizable=yes,scrollbars=yes,width=230');return false;\" target=\"smilies\" class=\"nav\">$smilies_more</a></td>";

Similarly line:
<td colspan=\"$s_colspan\" class=\"nav\"><a href=\"$url\" onclick=\"window.open('$url', '_smilies', 'height=200,resizable=yes,scrollbars=yes,width=230');return false;\" target=\"_smilies\" class=\"nav\">$smilies_more</a></td>

needs same change
<td colspan=\"$s_colspan\" class=\"nav\"><a href=\"$url\" onclick=\"window.open('$url', 'smilies', 'height=200,resizable=yes,scrollbars=yes,width=230');return false;\" target=\"smilies\" class=\"nav\">$smilies_more</a></td>
by: NanoCaiordo
This bug has been fixed in the CVS.

Snapshots of the sources are packaged every 6 hours; this change
will be in the next snapshot. You can grab the snapshot at the
Downloads section.

Thank you for the report, and for helping us to make Dragonfly 9.0.3 -> 9.2 better.
User Info

Welcome Anonymous



(Register)
Community

Support for DragonflyCMS in a other languages:

Deutsch
Español