Projects ⇒ Bugs ⇒ #658: Pagination links do not include selected topic (with fix) ⇒ CPG Dragonfly™ CMS
Bug #658 Pagination links do not include selected topic (with fix)
Project: Dragonfly 9.0.3 -> 9.3 Category: News
Submitted: Wednesday, November 02, 2005 (03:15:37) Modified: Sunday, November 13, 2005 (03:11:06)
Status: Closed Assigned to: akamu
PHP Version: Irrelevant HTTPD Server: Apache 1.3
Votes: 1
Vote results:
Avg. Score: 4.0 ± 0.0 Reproduced: 1 of 1 (100.0%)
Same PHP Version: 0 (0.0%) Same HTTPD Server: 0 (0.0%)

View/Vote Add Comment

by: Biggles
Description:
------------
The pagination links do not include the currently selected topic so they will take the user to the full list of news articles rather than to topic specific articles.

Suggested fix:
Change line 180 of modules/News/index.php (CVS) to:
pagination('News' . ( 0 < $topic ? '&amp;topic=' . $topic : '' ) . '&amp;page=', $pages, 1, $page);
by: Purus
The suggest fix above works nicely to make sure the pagination
links to individual topic pages when you are viewing an
individual topic, but it doesn't do the pagination based on
that topic, so you will have the wrong number of pages down
there, and when you try to click on page 33 for an individual
topic that doesn't have that many pages, it will just return a
page not found.
by: Purus
Never mind that last comment. I downloaded the latest CVS
file, and then applied the fixed mentioned above, and it all
works great now. Please include this fix in the next release.
by: Purus
Never mind that last comment. I downloaded the latest CVS
file, and then applied the fixed mentioned above, and it all
works great now. Please include this fix in the next release.
by: akamu
This bug has been fixed in the CVS.

Snapshots of the sources are packaged every 6 hours; this change
will be in the next snapshot. You can grab the snapshot at the
Downloads section.

Thank you for the report, and for helping us to make CPG-Nuke 9.0.3 -> 9.1 better.

thanks biggles and purus
/cvs/html/modules/News/index.php,v <-- index.php
new revision: 9.14; previous revision: 9.13
User Info

Welcome Anonymous



(Register)
Community

Support for DragonflyCMS in a other languages:

Deutsch
Español